Pcbnew drill sizes statistics

Bug #1841144 reported by David Pearce on 2019-08-23
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Wishlist
Mikołaj Wielgus

Bug Description

Wishlist item:
6.00 development now has a statistics output.
It would be helpful to be able to summarize drill sizes used in a project

Changed in kicad:
status: New → Triaged
importance: Undecided → Wishlist
tags: added: pcbnew starter
Mikołaj Wielgus (mwielgus) wrote :

I would like to kindly ask for any feedback. My previous patch, posted few weeks ago, was not addressed by anyone.

Changed in kicad:
assignee: nobody → Mikołaj Wielgus (mwielgus)
status: Triaged → In Progress
Seth Hillbrand (sethh) wrote :

@Mikołaj - My apologies, I did not see the previous patch. Was it sent to the list or posted elsewhere?

Looking over your patch, it looks like a good addition. There are some KiCad style issues that will be resolved by using our coding style formatter (tools/check_coding.py). These are primarily spacing.

I have a few things that would be good to tighten up:
1) Rather than using ( *it ).data I would prefer that you use it->data
2) Please place your sort function in the structure it is sorting by overloading the operator<
3) The drillData and drillType structures are degenerate. Please combine them into the same structure.
4) Function parameter names should be in camelCase but start with the letter 'a'. So, examples of this would be aParameterOne and aOtherType

Others may have additional comments. Thank you for taking the time to address this issue!

Mikołaj Wielgus (mwielgus) wrote :

@Seth

Thank you for your response.

My previous patch was posted here: https://bugs.launchpad.net/kicad/+bug/1016464 .

Mikołaj Wielgus (mwielgus) wrote :

I've performed the changes as you requested, with exception to point 2. Instead of overloading operator< I've added a functor, since the comparison function needs to know what column it is sorting by -- if you know a better solution, please tell me.

Mikołaj Wielgus (mwielgus) wrote :

Since I left few mistakes in my last patch, I'm attaching another one here.

I look forward to any response. Should I, perhaps, post this patch on the mailing list?

Changed in kicad:
milestone: none → 6.0.0-rc1
Changed in kicad:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers