Segfault when modyfying footprint description (MacOS)

[Christoph Nieß]

I can't reproduce this one, but the crash dump might be interesting.

I had just made a new footprint, then opened its settings and typed a few words into the description field. Crash occured while typing, but part of the text had already shown up.

Version info:
Application: ModEdit
Version: (5.1.0-1458-gf057bfc7c), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.7.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=OFF
    KICAD_SANITIZE=OFF

[Ian McInerney (imcinerney)]

Hmm, this looks like it is due to a menu problem.

@Christoph, was this install built since Tuesday? (I can't read the mac version string very well because there seems to be some commits that aren't in master).

@Jeff, I think this is related to the idle processing of the menu that you added to fix the preferences. It seems like it is checking for if the key press would match a menu action, but the menu is no longer there to access.

[Jeff Young (jeyjey)]

@Ian, yes, I expect you’re right. I’m currently testing a fix in our local wxWidgets branc that will allow us to remove our hack.

[Jeff Young (jeyjey)]

This is likely now fixed. (I've removed the menu hack in favour of a fix in our local wxWidgets branch.)

[Christoph Nieß (toffi-mixedstuff)]

@Ian, it's the official nightly build tagged 2019-08-07, so Wednesday (I'm still running on that one).