Eeschema: arc rendering difference between 5.0 and 5.1

Bug #1838557 reported by Wayne Stambaugh on 2019-07-31
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Medium
Seth Hillbrand

Bug Description

Someone sent me the following library and screen captures of an arc rendering change between the 5.0 (5.0.2) and 5.1 (5.1.2) releases that broke some arc definitions. I confirmed this so it's definitely an issue. I cannot figure out how this one slipped through the cracks. The problem also exists in the master branch.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :
description: updated
tags: added: eeschema
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 643c7f25f567e8de8fc5a0aabe148c2d914da55f
https://git.launchpad.net/kicad/patch/?id=643c7f25f567e8de8fc5a0aabe148c2d914da55f

Changed in kicad:
status: Triaged → Fix Committed
assignee: nobody → Seth Hillbrand (sethh)
Revision history for this message
Seth Hillbrand (sethh) wrote :

Hi Wayne-

Dangers of overdefining here. SnapEDA generated coordinates that we never generate in libedit and depended on our rounding to correct this. The rounding used angle difference to setup the start/end coordinates for legacy draw.

GAL doesn't use start/end coordinates, so we did the technically correct procedure of just using angles. Unfortunately, this lost the edge case where we depending on the rounding direction and not just the angle. The solution is an ugly hack that re-forces the wxWidgets-like dependency.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@Seth, thanks for fixing this. I agree it's less than ideal but the broken rendering had to be fixed. Had we not rendered differently with the legacy canvas, this wouldn't be an issue.

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers