Footprint editor text tool locks cursor when cancelled

[Ian McInerney]

The following is for the footprint editor.

When the text tool dialog is cancelled without doing anything, the crosshairs no longer move with the cursor.

The attached capture shows the following:
1) Starting the text tool while the polygon tool is active (crosshair moves)
2) Cancelling the text tool dialog after clicking once (crosshair no longer moves)
3) Start polygon tool, then go back to text tool (crosshair moves)
4) Cancelling the text tool dialog after clicking once (crosshair no longer moves)
5) Cancel text tool with ESC (crosshair moves)
6) Reactivate text tool (crosshair no longer moves)

This behavior exists in both 5.1 and master

Application: ModEdit
Version: (5.1.3-11-gc8278f377), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1c zlib/1.2.11 brotli/1.0.7 libidn2/2.1.1 libpsl/0.20.2 (+libidn2/2.0.5) libssh/0.8.7/openssl/zlib nghttp2/1.37.0
Platform: Linux 5.1.18-300.fc30.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.65.3
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision 3f28a1d1cb1fa29f023057981573a3b0bdf0968a
https://git.launchpad.net/kicad/patch/?id=3f28a1d1cb1fa29f023057981573a3b0bdf0968a

[Jeff Young (jeyjey)]

Code has diverged so 5.1 branch will need its own fix.