EESchema - <enter> or Find button attempts to advance to second hit

[Art]

If I try to find a symbol in an existing schematic and type it's name in the Find text box, that symbol reference field becomes highlighted but the cursor doesn't move to the symbol. That doesn't help me at all if the symbol is off the screen or more frequently under the Find pop-up window. Now if I hit the Find button I get the message about reaching the end of the schematic and nothing being found. Only if I hit Find button again will it actually move the cursor to the symbol.

A couple of things here. The cursor behavior in EESchema need to copy that of PCBNew. If I have both windows open and run a search in EESchema, PCBNew actually behaves as you would expect it and pans and zooms on the desired footprint and highlights it even before the Find button is pressed. Second, Find pop-up dialog should never cover the results of the search. It is a good feature to remember its last position, but the default position should be somewhere else, rather than the center of the screen. Better yet forget Win 3.11 style search and have a simple text box in the the GUI panel along with the rest of the buttons and add an options drop down list where you can tune parameters for your search.

[Art (diametrix)]

Application: KiCad
Version: (5.1.0-1338-g346495ae3), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

There does seem to be an off-by-one error here.

But I'm surprised that the hits are appearing under the Find dialog. It works fine on the Mac (the hit is moved out to the largest un-occulted area of the document). It's not perfect if you're zoomed in because we're moving the center of the symbol rather than the text that was found, but it seems pretty good.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 2af41e87f937ad73fc6eb8bea53c79adaaa083d1
https://git.launchpad.net/kicad/patch/?id=2af41e87f937ad73fc6eb8bea53c79adaaa083d1