PCBNew "Push Pad Properties" incorrectly changes pads with different orientation

[Adam DeMuri]

I have a TQFP32-08 footprint from Sparkfun. When I use the "Push Pad Properties" tool, the "Do not modify pads having a different orientation" option does not seem to work. When using the tool on a vertical pad, the horizontal pads are also affected (making them the wrong size). See the attached repro video.

Application: kicad
Version: 5.1.2-f72e74a~84~ubuntu18.04.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-54-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

@Adam, I suspect this is a bug in the footprint. All pads should have the same width and height, with the top/bottom having an orientation 90º apart from the left right. I suspect this footprint has all pads with the same orientation, but with the top/bottom pads having their widths/heights swapped from the left/right pads.

[Jeff Young (jeyjey)]

Note that "TQFP-32_7x7mm_Pitch0.8mm" in the 4.0 libraries does /not/ have this bug. I don't know about the 5.0 libraries, or if Adam got this footprint from somewhere else....

[Michael Kavanagh (michaelkavanagh)]

Can you upload a copy of the footprint?

[Adam DeMuri (adam-demuri)]

Ah, looks like that's the case - all of the pads have an orientation of 0. Attached the footprint in question.

[Jeff Young (jeyjey)]

@Adam, did the footprint come from the Kicad libraries? If so they have their own bug-tracker at: https://github.com/KiCad/kicad-footprints/issues.

Cheers,
Jeff.

[Adam DeMuri (adam-demuri)]

Nope, this came from https://github.com/sparkfun/SparkFun-KiCad-Libraries

[Jeff Young (jeyjey)]

Cool. I logged a bug with them:

https://github.com/sparkfun/SparkFun-KiCad-Libraries/issues/5