MacOS CMD+Q quits everything

Bug #1835454 reported by ocb-hd-ccb on 2019-07-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Low
Ian McInerney

Bug Description

Request:

Go back to previous functionality where "CMD + Q" closes just the currently focused application: Eeschema, PCBNew, GerbView, ect.

Current functionality is "CMD + Q" quits all of Kicad and associated applications.

Acceptable compromise: Implement "CMD + W" to close current window and "CMD + Q" to quit everything. although since they are separate applications this would seem very foreign to the normal MacOS way.

Application: KiCad
Version: (5.1.0-1195-gcea9cd417), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.6.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Seth Hillbrand (sethh) wrote :

Cmd-W was supposed to link to close window but it looks like Mac didn't pick it up...

Changed in kicad:
assignee: nobody → Seth Hillbrand (sethh)
importance: Undecided → Low
milestone: none → 6.0.0-rc1
status: New → In Progress
tags: added: hotkeys macos ui
removed: feature.request
ocb-hd-ccb (ocb-hd-ccb) wrote :

I guess this is "low priority" but it is still an issue in the latest nightly.

```
Application: KiCad
Version: (5.1.0-1387-g7808f92c8), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.7.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
```

Jeff Young (jeyjey) wrote :

I believe the Cmd-W issue was fixed by some recent work Ian and I did on another bug....

Changed in kicad:
status: In Progress → Fix Committed
ocb-hd-ccb (ocb-hd-ccb) wrote :

Great! I will pull the nightly and give it a shot.

@Jeff, not sure whether it was intentional but looks like Libedit and Modedit were forgotten.

Jeff Young (jeyjey) wrote :

Oh, right, because they're not separate binaries....

ocb-hd-ccb (ocb-hd-ccb) wrote :

Also, the "3D Viewer"

ocb-hd-ccb (ocb-hd-ccb) wrote :

and "pcb calculator"

Jeff Young (jeyjey) wrote :

PCBCalculator is a separate app whose menubar is built by wxWidgets.

CvPcb: cmd-Q closes CvPcb and cmd-W does nothing.

Changed in kicad:
status: Fix Committed → In Progress
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 8493daf9fff4bde501bb31b6e3468ec99bdcb8ee
https://git.launchpad.net/kicad/patch/?id=8493daf9fff4bde501bb31b6e3468ec99bdcb8ee

Changed in kicad:
status: In Progress → Fix Committed
assignee: Seth Hillbrand (sethh) → Ian McInerney (imcinerney)
Ian McInerney (imcinerney) wrote :

Ok, lets try this now. The most recent change pushed CTRL-W (or cmd-W for mac) into all the windows that have a Close item in their menubar.

The assign footprints window doesn't have a CTRL-Q handler, and I believe we are treating it as a "dialog" window of Eeschema now, (so it also allows ESC to close it).

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers