eeschema page settings: disabled text in comment one and zoom after OK

[Martin Thomas]

When I open the frame description, the text in comment field 1 is grey.
Also after I click on OK the sheet zooms out.

Application: Eeschema
Version: (5.1.0-1149-g981072598-dirty), debug build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 GnuTLS/3.5.8 zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 5.1.7-mt x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

I can't reproduce the gray text part.

The zooming is intentional (I guess to show what you've changed), although that doesn't mean it's a good idea.

@Devs, opinions on the zooming?

[Jeff Young (jeyjey)]

Ping.

[Seth Hillbrand (sethh)]

Yeah, I prefer to skip the zoom out at the end too.

The grey text is caused by it being highlighted. We use the system colors, so this is likely the result of the color scheme chosen. @Martin, can you select a different highlight setting in your system configuration panel and see if that helps?

[Jeff Young (jeyjey)]

I'll take that as a +1 from Seth and me. I'll give it another day or two before making the change....

[Jeff Young (jeyjey)]

I played with that a bit, and it doesn't feel right. If I highlight a net, go to the track tool and then hit <esc> I expect to cancel the track tool but it also cancels the net highlighting. I think we only want to clear the net highlighting when there's nothing else left to clear.

[Jeff Young (jeyjey)]

Rats. Replied to wrong bug report.

[Jeff Young (jeyjey)]

Removed post-PageSettings() ZoomFitToScreen() calls from Eeschema, PLEditor and PCBNew.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 772dff7a018f5dcb76e0182d8b311a13dfe168f0
https://git.launchpad.net/kicad/patch/?id=772dff7a018f5dcb76e0182d8b311a13dfe168f0