Eeschema: add power symbol hotkey does not work on GTK

[Seth Hillbrand]

Using the default power hotkey (p) in Eeschema (fresh config directory) to place a new power symbol does not appear to work. There is no effect. Changing the hotkey to "Shift + P" causes the hotkey to work again.

Application: Eeschema
Version: (5.1.0-1148-g42e14b5a4), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1c zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

Works for me on OSX. @Seth, if you have a chance can you confirm if this is GTK-specific?

[Seth Hillbrand (sethh)]

Digging into this more, it looks like there is a new action in eeschema called "Add Pin" that is assigned to 'P' by default. I think this might be bleed-over from libedit where it shouldn't.

[Jeff Young (jeyjey)]

Given that I thought it might reproduce on OSX if I had LibEdit running. But no.

(And upon further reflection that was a dumb idea since LibEdit and Eeschema aren't separate binaries anymore.)

Still hard to imagine how it's GTK-specific though....

[Seth Hillbrand (sethh)]

Do you see the pin hotkeys for assignment in Preferences when you are running just Eeschema?

[Jeff Young (jeyjey)]

@Seth, yes I see them even with just eeschema running.

I wonder if this was fixed by JP's recent hotkey fixes. Could you test it again?

[Jeff Young (jeyjey)]

@Seth, have you had a chance to test this again after JP's and my hotkey fixes?

[Seth Hillbrand (sethh)]

Yup. Still no joy :(

Application: Eeschema
Version: (5.1.0-1319-g9fae30162), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1c zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Ian McInerney (imcinerney)]

It appears that the hotkey is being stolen by the place symbol pin action and so the tool dispatcher isn't running the place power symbol action. A patch sent to the developer list a while ago (https://<email address hidden>/msg36318.html) should fix this by trying all actions until it is handled (since the place symbol pin doesn't handle the action).