eeschema copy-paste hierarchical sheet does not un-annotate components

[Dino Ghilardi]

When you paste a hierarchical sheet, the components of the new copy are not un-annotated, so you get double references in the desgn.

To reproduce the behaviour:
-Create a hierarchical sheet
-put a component in it (as a resistor)
-annotate the design
-go to the master sheet, select the hierarchical sheet box, copy and paste
-the newly created child sheet has still the components annotated, with the same references of the copied sheet.

Tested on revision b5cf03f5adadbfe1373abb92eafa6757a0ff6ff6

Application: Eeschema
Version: (5.1.0-1045-gb5cf03f5a), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 OpenSSL/1.0.2r zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Dino Ghilardi (dino-ghilardi)]

In stable version 5.1.2 it is working correctly.

[Wayne Stambaugh (stambaughw)]

We should probably keep the same behavior as the 5.1 branch although there may be some users who prefer keeping the current annotation.

[Dino Ghilardi (dino-ghilardi)]

The current annotation is not a re-annotation, but keeps duplicate references, so forces the user to manually un-annotate and re-annotate the components in the new sheet or it won't be able to generate the netlist for pcbnew, run the ERC or even annotate the schematic (in this case you get "Error: multiple item ..."), so I think the new behaviour has to be changed anyway.

I agree.
We could consider either:
1 automatic re-annotation of the components of the pasted sheet
or
2 un-annotate the "pasted" one (the way of the 5.1 branch)

Considering that
-Automatic re-annotation does not give a relevant advantage over the 5.1 branch behaviour
-The default behavior when a new component is placed or pasted is not to automatically annotate it

the cleaner way seems "keep the 5.1 way", so that the behaviour between pasting a single component or pasting an entire sheet is the same (create an un-annotated copy)

Cheers,
Dino.

[KiCad Janitor (kicad-janitor)]

Fixed in revision c77d214c5fde26aa57e4ad56cabe881b5388825a
https://git.launchpad.net/kicad/patch/?id=c77d214c5fde26aa57e4ad56cabe881b5388825a