Fix for #1831643 breaks MSVC builds
Bug #1832357 reported by
Simon Richter
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| KiCad |
Fix Committed
|
Undecided
|
Simon Richter | ||
Bug Description
Commit 720889edd seems to fix this bug for Linux builds, but the build fails because the lexer header files cannot be opened.
Build order seems to be okay, the file is created long before it is used, so this is likely a problem with the include path (where MSVC is generally a lot more sensitive), so the fix might have changed project dependencies and therefore inherited compiler settings.
| Changed in kicad: | |
| assignee: | nobody → Simon Richter (sjr) |
| Changed in kicad: | |
| milestone: | none → 5.1.3 |
Revision history for this message
| Seth Hillbrand (sethh) wrote | #1 |
| Changed in kicad: | |
| milestone: | 5.1.3 → none |
Revision history for this message
| KiCad Janitor (kicad-janitor) wrote | #2 |
| Changed in kicad: | |
| status: | New → Fix Committed |
To post a comment you must log in.
I'm going to remove the milestone because we don't use MSVC for the official builds yet. So this issues shouldn't block release.
@Simon, let me know if I can help here