pcbnew: Action plugins not running

[Ian McInerney]

The action plugins in pcbnew are not running when they are selected from the submenu. To reproduce, extract the dummy python plugin into a plugins directory (e.g. ~/.kicad_plugins on linux).

1) Launch pcbnew
2) Go into Tools -> External Plugins
3) Select "Dummy Plugin 3"
Note that no popup window opens. If the plugin had run, a popup would open.

Application: Pcbnew
Version: (5.1.0-868-g0ea75cb4e), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.59.0 OpenSSL/1.1.0i zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) libssh/0.8.6/openssl/zlib nghttp2/1.32.1
Platform: Linux 5.0.16-100.fc28.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.66.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.59.0
    Compiler: GCC 8.3.1 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Ian McInerney (imcinerney)]

This was caused by the event handler for the action menu sending the events for the action plugins to the tool associated with the menu instead of to the event handler associated with the item. The attached patch makes the action menu event handler forward events for auto-generated IDs to the user-connected handler instead of a tool manager.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 6f8a0a4eed7c10c43adee38a49bc30c2e8de303f
https://git.launchpad.net/kicad/patch/?id=6f8a0a4eed7c10c43adee38a49bc30c2e8de303f

[jean-pierre charras (jp-charras)]

Thanks Ian.

I committed a fix.
I am not sure the filtering in your patch is good, but it really helped me.