eeschema: "unfold from bus" (right click menu) and "unfold from bus" ("C" shortcut) beheave in a (slightly) different way

Bug #1831466 reported by Dino Ghilardi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Low
Jeff Young

Bug Description

The "c" shortcut and the right click menu "Unfold from bus" work a little bit different:

-Using the right click menu "unfold from bus" if the bus is not "on grid" the wire-to bus entry does not connect graphically to the bus but goes to the nearest "in grid point" (I don't know if this should considered a bug or a feature. May be a warning on the fact it is not on grid should be appreciated by the user, but I'm not sure on it since it can be personal)
-Trying to do the same using the "c" shortcut gives "no bus selected" even if a bus has been selected using the mouse, so the (wrong) impression to the ones who use the shortcuts is that the bus has something wrong or is not working.

Workaround: place buses on the current grid or try the right-click menu when you receive a "no bus selected".

Tags: eeschema
Revision history for this message
Jon Evans (craftyjon) wrote :

Not really sure how we should address this -- all of the "immediate actions" (including the hotkey for unfolding bus) run a selection first based on the grid point nearest the cursor, but the right-click menu operates on whatever is actually selected. I'm not sure how much extra work we want to put in to supporting "off grid" editing using immediate action hotkeys, since the right answer is probably to just put all your stuff on the grid :-)

We could make it a bit less confusing by removing the "no bus selected" popup menu when the unfold action is triggered by hotkey. This would make it more consistent with the other actions that do nothing when there is no nearby on-grid item (drag, for example)

Revision history for this message
Jon Evans (craftyjon) wrote :

@Jeff do you have opinions about this one?

Revision history for this message
Jeff Young (jeyjey) wrote :

@Jon, I agree that just removing the "no bus selected" message when from immediate action is probably sufficient.

Jeff Young (jeyjey)
Changed in kicad:
status: New → Triaged
importance: Undecided → Low
milestone: none → 6.0.0-rc1
Jeff Young (jeyjey)
Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
status: Triaged → In Progress
Revision history for this message
Jeff Young (jeyjey) wrote :

This didn't end up having anything to do with the grid: it's just that we were clearing the selection before popping up the menu in the hotkey case.

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision cc93d8202599cf252f1d293c21991f3a72d011b8
https://git.launchpad.net/kicad/patch/?id=cc93d8202599cf252f1d293c21991f3a72d011b8

Changed in kicad:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.