EEschema [Nightly] Edit symbol proprieties

[Michele Giorato]

Every time you touch the "value" content in Eeschema/SymbolProperties, then when you go to close it appears:

ASSERT INFO:
../src/common/wincmn.cpp(477): assert "GetEventHandler() == this" failed in ~wxWindowBase(): any pushed event handlers must have been removed

BACKTRACE:
[1] wxWindowBase::~wxWindowBase()
[2] wxTextCtrl::~wxTextCtrl()
[3] wxWindowBase::Destroy()
[4] wxWindowBase::DestroyChildren()
[5] wxWindow::~wxWindow()
[6] wxWindowBase::Destroy()
[7] wxWindowBase::DestroyChildren()
[8] wxWindow::~wxWindow()
[9] wxWindowBase::Destroy()
[10] wxWindowBase::DestroyChildren()
[11] wxWindow::~wxWindow()
[12] wxWindowBase::Destroy()
[13] wxWindowBase::DestroyChildren()
[14] wxWindow::~wxWindow()
[15] make_fcontext

--------------------------------

Application: Eeschema
Version: 6.0.0-unknown-r15909-4842c735, debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1b zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.20.2 (+libidn2/2.0.5) libssh/0.8.7/openssl/zlib nghttp2/1.38.0
Platform: Linux 5.0.17-300.fc30.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 9.1.1 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Michael Kavanagh (michaelkavanagh)]

I cannot recreate this on macOS.

Application: Eeschema
Version: (5.1.0-828-g17b18637f), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.5.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 10.0.1 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Michele Giorato (mr-miky64)]

Well your configuration is VERY different from mine ...

[Seth Hillbrand (sethh)]

I am unable to recreate this using current master on Linux

Application: Eeschema
Version: (5.1.0-834-g256d7b071-dirty), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1b zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Michele Giorato (mr-miky64)]

I guess we're not comparing the same versions

sethh -> Application: Eeschema
Version: (5.1.0-834-g256d7b071-dirty), debug build

Michael -> Application: Eeschema
Version: (5.1.0-828-g17b18637f), debug build

mine -> Application: Eeschema
Version: 6.0.0-unknown-r15909-4842c735, debug build

[Seth Hillbrand (sethh)]

Hi Michele-

Both Michael and I are using recent master versions. Where did you download your copy?

[Michele Giorato (mr-miky64)]

https://copr.fedorainfracloud.org/coprs/g/kicad/kicad/

every night is compiled and put online ...

[Seth Hillbrand (sethh)]

@StevenFalco - Can you reproduce this behavior?

[Ian McInerney (imcinerney)]

@Seth, I just tried the COPR nightly and I can't reproduce the behavior on my Fedora machine.

[Ian McInerney (imcinerney)]

Here is the version info from my kicad install. I am running slightly older versions of the libraries since I am on F28, so maybe there is a problem with newer versions.

@Michele, which version of Fedora is this running on?

Application: KiCad
Version: 6.0.0-unknown-r15960-cbea5149, debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.59.0 OpenSSL/1.1.0i zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) libssh/0.8.3/openssl/zlib nghttp2/1.32.1
Platform: Linux 5.0.16-100.fc28.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.66.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.59.0
    Compiler: GCC 8.3.1 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Steven Falco (stevenfalco)]

I tried both r15909 and r15960 on Fedora 30. No asserts here. I changed the value property of a resistor several times, both standalone and running eeschema from the project tool.

If the reporter still sees it, we may need a more detailed recipe to reproduce it.

[Michele Giorato (mr-miky64)]

I probably misunderstood how to get the bug to appear.

The alert appears when I close the requester not when I click on the field to change it or when I change it.
It is indifferent whether I change the contents of the field or not, just activate the textedit and then close.

[Michele Giorato (mr-miky64)]

Further tests:

I noticed that it happens if you go to "touch" the fields that are not related to the library but to the global ones defined by the user and proper to the project itself

[Jeff Young (jeyjey)]

Ah, excellent. Reproduces easily that way.

[KiCad Janitor (kicad-janitor)]

Fixed in revision dfcffddbe4e4e3cf140bb93720a13f5cb2f6bb37
https://git.launchpad.net/kicad/patch/?id=dfcffddbe4e4e3cf140bb93720a13f5cb2f6bb37

[Steven Falco (stevenfalco)]

I too can reproduce the error now, by adding a field to a symbol.

I tried building a local copy to test Jeff's fix, but the build failed because template_fieldnames_lexer.h was messed up. I think this is the "build race condition" that was discussed on the mailing list a few days ago.

[Steven Falco (stevenfalco)]

Using the new recipe I was able to reproduce the bug here.

I then built and tested with Jeff's fix, and it corrects the bug. Good job Jeff!