Dragging a wire which has a junction cause a disconnection

Bug #1831199 reported by ali teke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Medium
Jeff Young

Bug Description

Application: Eeschema
Version: (5.1.0-783-g669520924), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 OpenSSL/1.0.2l zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-4-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010
Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: eeschema
Revision history for this message
ali teke (aliteke2004) wrote :
Changed in kicad:
milestone: none → 6.0.0-rc1
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

Something has definitely changes with regards to wire dragging. See attached screen cast.

Changed in kicad:
status: New → Triaged
importance: Undecided → Medium
Jeff Young (jeyjey)
Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
status: Triaged → In Progress
Revision history for this message
Jeff Young (jeyjey) wrote :

This was the result of trying to fix bugs in 5.x where we'd pick up too much stuff. But now we don't pick up enough.

So instead I'm going to go to the "add wires" strategy, which worked really well for directly connected components.

Let me know how it works for you guys....

Revision history for this message
Jon Evans (craftyjon) wrote :

Looking forward to trying "add wires" to see how it feels. The old behavior (of picking up at least both control points of a given segment) seemed intuitive to me -- if I have H/V only mode turned on, I would expect dragging a given segment to always drag both control points, and have other wires attached to the segment also be dragged in a H/V only manner (possibly adding more segments as needed)

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 1dd1ddf83bd372c3672d5a7c496e91b6e7fc0a5c
https://git.launchpad.net/kicad/patch/?id=1dd1ddf83bd372c3672d5a7c496e91b6e7fc0a5c

Changed in kicad:
status: In Progress → Fix Committed
Revision history for this message
ali teke (aliteke2004) wrote :

Thanks for the fast response, it works good now. In addition it comes much better to me when i comment out below code, can you please check attached videos.

diff --git a/eeschema/tools/sch_move_tool.cpp b/eeschema/tools/sch_move_tool.cpp
index 7cb2dd85b..779d6fd54 100644
--- a/eeschema/tools/sch_move_tool.cpp
+++ b/eeschema/tools/sch_move_tool.cpp
@@ -272,7 +272,7 @@ int SCH_MOVE_TOOL::Main( const TOOL_EVENT& aEvent )
                 // Set up the starting position and move/drag offset
                 //
                 m_cursor = controls->GetCursorPosition();
-
+/*
                 if( selection.HasReferencePoint() )
                 {
                     m_anchorPos = selection.GetReferencePoint();
@@ -283,7 +283,7 @@ int SCH_MOVE_TOOL::Main( const TOOL_EVENT& aEvent )
                         m_cursor = *m_anchorPos;
                     }
                 }
-
+*/
                 if( m_anchorPos )
                 {
                     VECTOR2I delta = m_cursor - (*m_anchorPos);

Revision history for this message
ali teke (aliteke2004) wrote :
Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :
ali teke (aliteke2004)
Changed in kicad:
status: Fix Committed → Confirmed
status: Confirmed → Fix Committed
Revision history for this message
ali teke (aliteke2004) wrote :

Oh you right, it's the same bug.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.