3D shapes library wizard not updating library list

Bug #1830137 reported by Ian McInerney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Undecided
Ian McInerney

Bug Description

The 3D shapes library wizard in pcbnew is not displaying the correct library list. When first opened the list is blank, and is only populated by trying to search (or going back to the 1st page and back). If the URL is modified on the 1st page, then the library list is never updated to reflect the contents at the new URL.

Reproduction:
1) Open the 3D shapes libraries wizard (in Preferences)
2) Leave the URL the default
3) Click next
4) Note that the library list is empty
5) Type anything in the search box, the list now populates
6) Go back to the first page
7) Edit the URL to an invalid one (add random characters to the end)
8) Click next
9) The library list still contains the list from the previous URL

This was tested on a build from the head on the 5.1 branch.

Application: Pcbnew
Version: (5.1.2-54-g5a655779d-dirty), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.59.0 OpenSSL/1.1.0i zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) libssh/0.8.6/openssl/zlib nghttp2/1.32.1
Platform: Linux 5.0.9-100.fc28.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.66.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.59.0
    Compiler: GCC 8.0.1 with C++ ABI 1012

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: pcbnew
Revision history for this message
Ian McInerney (imcinerney) wrote :

The attached patch makes the list update when the page is first visited. It also updates the list on any change to the text in the URL box.

Changed in kicad:
assignee: nobody → Ian McInerney (imcinerney)
Revision history for this message
Seth Hillbrand (sethh) wrote :

Looks good. Thank you for your contribution to KiCad!

Changed in kicad:
milestone: none → 5.1.3
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 0daf14f9c36aa027b52ee27eaeb4d863b2571568
https://git.launchpad.net/kicad/patch/?id=0daf14f9c36aa027b52ee27eaeb4d863b2571568

Changed in kicad:
status: New → Fix Committed
tags: added: pcbnew
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.