Assert then crash on quit

[Michael Kavanagh]

Application: Eeschema
Version: (5.1.0-610-g813de6a1f), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.5.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 10.0.1 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Nick Østergaard (nickoe)]

If you click yes, it will crash by design.

[Jon Evans (craftyjon)]

I'm having trouble reproducing this. Probably it matters what you were doing in eeschema before you quit -- can you recreate any of the steps you were doing that cause this assertion?

[Michael Kavanagh (michaelkavanagh)]

@Jon, One way I can get this to reproduce reliably is by selecting a tool (line, wire etc) from the toolbar, hitting Esc then quitting Eeschema.

[Jeff Young (jeyjey)]

I never got the crash, but I have fixed the assert.

[KiCad Janitor (kicad-janitor)]

Fixed in revision d3777eaddf60fe5e556c0ee010315156510356b3
https://git.launchpad.net/kicad/patch/?id=d3777eaddf60fe5e556c0ee010315156510356b3