Create item, then array: undo also removes item

[John Beard]

Pcbnew nightly, 69afa27a5:

1) Create a item (eg, a via, or a line segment), can be on a blank canvas
2) Ctrl-T, make an array of it
3) Ctrl-Z: expected the array is removed and the item remains. What happens: the array *and* the item are removed.

This does not happen in the prior commit (f9e4ee1fc).

----

Application: Pcbnew
Version: (5.1.0-568-g69afa27a5), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.1 OpenSSL/1.1.1b zlib/1.2.11 libidn2/2.1.1 libpsl/0.20.2 (+libidn2/2.1.1) libssh2/1.8.1 nghttp2/1.36.0
Platform: Linux 5.0.12-arch2-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.1
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

@John, does this still reproduce for you? I can't make it happen.

To get ctrl-T to work I have to put in a couple of extra steps:

1) Create via or line segment
1.1) Cancel current tool or click on arrow tool
1.2) Select item created in (1)
2) Ctrl-T

Is there some other way to do this without 1.1 and 1.2? (Perhaps that's the difference.)

[John Beard (john-j-beard)]

@Jeff, this does now appear to be working (8a5d80304). Perhaps it's something that's been incidentally fixed with the recent work in the area. I could bisect for the actual fix, but that'd take all night.

[Jeff Young (jeyjey)]

Excellent!