Crash in Footprint Properties/3D Settings

[Konstantin Tokar]

Problem: KiCAD footprint editor and all other editors crashes when trying to delete a 3D model in an empty list.

Reproducibility: always

Steps to reproduce:
1. Start Kicad
2. Start PCB footprint editor
3. Load any footprint
4. Enter "Footprint properties"
5. Enter "3D settings"
6. Remove all 3D Models (if exists)
7. Press "Ok"
8. Enter "Footprint properties"
9. Enter "3D settings"
10.Press basket button again (the list of models must be empty before this)
8. Crash

My Vetsion Info:

Application: kicad
Version: 5.1.2-f72e74a~84~ubuntu18.04.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-48-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision f32c95229eb32c7ef731b04e16c34701d3fd248f
https://git.launchpad.net/kicad/patch/?id=f32c95229eb32c7ef731b04e16c34701d3fd248f