Eagle import: "first pad" shape change should only be applied to pads specifically marked as first.

[Rene Poeschl]

The eagle file format includes a parameter "first" for every pad. The design rule setting "shape-> first pad" set to anything else than "not special" (psFirst != -1) should only change pads marked with this parameter no matter which pad number it has assigned.

A test project is attached. (One footprint has pad Nr.1 marked as first while the other does not. both get converted to squares by the eagle import of the current kicad version.)

---

eagle 9.3.2

Application: kicad
Version: (5.1.2)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision dbc40096db46c32ffe8f73377e831c6ca08ceab7
https://git.launchpad.net/kicad/patch/?id=dbc40096db46c32ffe8f73377e831c6ca08ceab7