eeschema: Repeat label numbering incorrect

[Chris Culpepper]

In eeschema, if you add a label with a number after it, pressing insert adds a new label with an incremented number below the previous one. With the latest version of kicad (Pulled from git and rebuilt ~yesterday), the numbering is incorrect, and the label properties do not match the displayed label. The label properties show the correct value. Closing and reloading the file shows the correct label number, but reloading the view does not.

Example (And reproduction steps):
Created label with name "xyz1". Pressing insert a few times yields:

xyz1
xyz1 <- Note the repeated "1", label properties shows expected xyz2
xyz2
xyz3
xyz4

When I close and reopen eeschema, the labels change to the expected values.

Version information:
Application: kicad
Version: (5.1.0-548-gee095a671), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.1 OpenSSL/1.1.1b zlib/1.2.11 libidn2/2.1.1 libpsl/0.20.2 (+libidn2/2.1.1) libssh2/1.8.1 nghttp2/1.36.0
Platform: Linux 5.0.10-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.1
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision 053c26c96e6b8c069628a34769fa05ebfb61176f
https://git.launchpad.net/kicad/patch/?id=053c26c96e6b8c069628a34769fa05ebfb61176f

[Chris Culpepper (cculpepper1214)]

That fixed it! Thanks Jeff!