Open Choose symbol continually

[Hildo Guillardi Júnior]

After press "a" and use once time the "Choose Symbol" dialog, every time that I click on Eeschema canvas, even after press several times <Esc>, the dialog opens again.
Because this behavior Eeschema doesn't allow do nothing after one component placed.

Other behavior that may be related:
To pick a symbol I have to:
1) Press <a> to cross cursor appear;
2) Press <Enter> in any part of the schematic to the dialog open.
Before the behavior didn't need the additional <Enter>, just press <a> to place at the current cursor possition.

Application: eeschema
Version: 5.1.0-unknown-ead5bfe~82~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.4.0-145-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

A modern tool's activation routine de-activates other tools. Legacy tools don't do this, so the last-selected modern tool will get "stuck" until another modern tool is chosen.

I've put a shim in for now to have legacy tools cancel modern tools.

[Hildo Guillardi Júnior (hildogjr)]

I just test now. The issue happens in both: legacy and modern.

[Jeff Young (jeyjey)]

Hi Hildo,

There's no such distinction in Eeschema. There is only the modern canvas, and the tools (in the nightlies) are currently about 1/2 and 1/2.

I only merged my changes about 10 minutes ago, though, so you'd need to do your own build to test them (or wait till tomorrow after the next nightly is built).

[Hildo Guillardi Júnior (hildogjr)]

True, sorry. It was fallback.

[Jeff Young (jeyjey)]

No worries. Let me know if it works for you when you get the new code.

(There's a bunch more tools moved over to the modern toolset too, so there will probably be other bugs.)

[Hildo Guillardi Júnior (hildogjr)]

Appear that last server built version still 16-04-2019. No new with this fix.