Partially broken undo in eeschema

[Ron Burkey]

If you perform an operation that (as a side effect) splits an existing wire into two parts and adds a junction, undoing that operation does not restore the wire properly.

I've attached an image that's a composite of several screenshots that illustrates the issue. The top of the image (labeled "A") is prior to any operation.

The middle of the image ("B") shows the result of an operation, which is moving an arrow-shaped object (which happens to be a PWR_FLAG), rotating it, and attaching it to the wire next to the net label "+3VDC", which splits the wire into two segments and adds a junction.

The bottom of the image ("C") is the result of an undo with ctrl-Z. The PWR_FLAG has moved back to its original position, but the original wire segment is not correctly restored. Subsequent undo's have no effect.

I hadn't noticed this problem prior to today's nightly build, so I suppose it may be a regression.

Application: kicad
Version: 5.1.0-unknown-e90452d~82~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.11 libidn/1.32 librtmp/2.3
Platform: Linux 4.4.0-53-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jon Evans (craftyjon)]

Probably duplicate of https://bugs.launchpad.net/kicad/+bug/1824251 -- will keep an eye on this

[Jon Evans (craftyjon)]

This should have been fixed by https://bugs.launchpad.net/kicad/+bug/1824251