Flipped Edge.Cuts in STEP export

[John Beard]

1) Place a footprint with Edge.Cuts
2) Flip the footprint to the back side of the board
3) Export STEP
4) Bug: the cutouts are in the wrong places (they are mirrored). Plot outputs are fine.

This is a strange footprint and the Edge.Cuts were not required (it came from an Eagle import), but the bug seems real enough.

In the attached board, the "R" footprint is flipped and rotated. The Gerbers are right, but the STEP is wrong.

Thanks to PoopieHead in IRC for the original footprint and the report.

----

Application: kicad
Version: (5.1.0-12-gc93e0b6c5), debug build
Libraries:
    wxWidgets 3.0.4
Platform: Linux 4.20.6-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Compiler: GCC 8.2.1 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=OFF
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Ian McInerney (imcinerney)]

This seems to be caused by only flipping the y-axis of the curves on the front layer. The attached patch flips all the curves (no matter the layer) to fix this. It is based on the current 5.1 branch.

[Seth Hillbrand (sethh)]

This seems to work correctly. I'm not sure the original purpose of only flipping the module edge cuts from the top.

@John have you had a chance to test this?

[Seth Hillbrand (sethh)]

@JohnBeard - ping if you have a chance to review this one, otherwise it looks good from my end.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 55261eb223e0ec0ebda381970d96d2985b52f20c
https://git.launchpad.net/kicad/patch/?id=55261eb223e0ec0ebda381970d96d2985b52f20c