The 'Edit-Undo' function does not roll-back page layout changes

Bug #1820059 reported by KiCad bug report
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Medium
Jeff Young

Bug Description

When trying to roll-back actions in the EeSchema application with the 'Edit-Undo' menu option (or CMD/CTRL-Z), page layout changes are not taken into account. In this case, I had changed the page orientation from landscape to portrait. Actions older than the page-layout change were taken into account when continuing to roll-back with the 'Edit-Undo' menu option (or CMD/CTRL-Z). I suppose that page-layout changes are not added to the roll-back list ?

Application: kicad
Version: (5.0.2-5)-5, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
Platform: Mac OS X (Darwin 17.7.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.51.0
    Compiler: Clang 8.0.0 with C++ ABI 1002
Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Seth Hillbrand (sethh)
Changed in kicad:
status: New → Won't Fix
status: Won't Fix → Triaged
importance: Undecided → Wishlist
Revision history for this message
Seth Hillbrand (sethh) wrote :

Our general approach with undo/redo has been to store the circuit changes not the presentation.

If someone does decide to implement this, it should be implemented across all 4 kifaces.

summary: - The 'Edit-Undo' function in EeSchema does not roll-back page layout
- changes
+ The 'Edit-Undo' function does not roll-back page layout changes
tags: removed: edit layout page undo
Revision history for this message
Jeff Young (jeyjey) wrote :

I understand that it wasn't part of the original design, and therefore isn't a /coding/ bug.

But we should consider it a design bug. Out users certainly will.

Changed in kicad:
importance: Wishlist → Medium
milestone: none → 6.0.0-rc1
Jeff Young (jeyjey)
Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
status: Triaged → In Progress
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 6936effaa7e26813f2938a759068b4d9f45a2e5e
https://git.launchpad.net/kicad/patch/?id=6936effaa7e26813f2938a759068b4d9f45a2e5e

Changed in kicad:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.