Crash on opening board setup dialog

[Michael Kavanagh]

Application: kicad
Version: (5.1.0-4-g5059b932c), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.4 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.2.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

@Seth, in 76600e343616ba016eefef5ab859bd7301effdf1 you changed the calculation of the m_originalColWidths and added a call to set the width. The SetColSize() call ends up sending a size event to the window, which then calls SETUP_NETCLASSES::OnSizeNetclassGrid(wxSizeEvent&) before we've initialized the rest of m_originalColWidths.

Is the SetColSize() call needed? We could put a re-entrancy check in, but the size event at the end of the constructor /should/ result in an OnSizeNetclassGrid() call to set all the column sizes.

[Seth Hillbrand (sethh)]

@Jeff- The column sizes are not correctly set under Linux, hence the extra effort there. We could add a Freeze() to the window before initializing the panels.

Also, this is an assert, not a crash. If Michael says continue instead of stop, what happens? Note, I cannot trigger this crash under Mac. Does it happen every time?

Application: kicad
Version: (5.1.0-4-ga47a8ca9b), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.4 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.2.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

I’ve had it happen once or twice, but I wasn’t paying attention to the steps. Clicking continue seems to be fine, but I’d rather not rely on it. The freeze/thaw seems like a reasonable idea.

[Michael Kavanagh (michaelkavanagh)]

It doesn't always happen first go, but closing the dialog and opening it again gets it (max three attempts needed for me).

The assert dialog keeps popping up every time you press continue (aka No button) and you can only progress if you suppress further warnings (Cancel button).

[KiCad Janitor (kicad-janitor)]

Fixed in revision a300ae105d3e2c17672d3482aa4f768eec97b79a
https://git.launchpad.net/kicad/patch/?id=a300ae105d3e2c17672d3482aa4f768eec97b79a