Tab navigation in footprint properties sets orientation to custom

[John Beard]

1) Open Edit footprint
2) Focus the "Position X" field (have to click due to https://bugs.launchpad.net/kicad/+bug/1810569)
3) Press tab, now in "position Y"
4) Press tab again, now in the "orientation" radio box (this might be non-obvious due to https://bugs.launchpad.net/kicad/+bug/1818999)
5) Press tab again, now in the "Other:" orientation field
6) Don't change it
7) Tab again, now in the "Board Side" field. However, the bug is that the orientation has also been changed on the loss of focus from the "Other:" field to be "Other/Custom".

This is annoying, as it is not expected for controls to be changed by tabbing though on the way to others.

It is a low-impact bug, as the custom orientation is kept up-to-date in the field, so it won't move the part.

---

Application: pcbnew
Version: (5.1.0-rc2-39-gd2d210117), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.63.0 OpenSSL/1.1.1a zlib/1.2.11 libidn2/2.1.0 libpsl/0.20.2 (+libidn2/2.1.0) libssh2/1.8.0 nghttp2/1.36.0
Platform: Linux 4.20.6-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.63.0
    Compiler: GCC 8.2.1 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision b6916c490c83774bfc5dc47aff497d4635aca3e9
https://git.launchpad.net/kicad/patch/?id=b6916c490c83774bfc5dc47aff497d4635aca3e9