StrNumCmp can trigger assertion error/segfault
Bug #1818157 reported by
Tomasz Wlostowski
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
KiCad |
Fix Released
|
High
|
Wayne Stambaugh |
Bug Description
Accidentally discovered while playing with MSVC Kicad build. StrNumCmp does not verify if the iterators (str1, str2) are pointing to a valid string character inside of the compare loop. On VS2017 it causes an immediate assertion failure, on some other platforms it may cause a plain segfault.
One of the 'impossible to reproduce' crashes?
Tom
Changed in kicad: | |
status: | New → Confirmed |
importance: | Undecided → High |
milestone: | none → 5.1.0 |
Changed in kicad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Update: it can also trigger an assertion in isdigit(), as this function does not support unicode, but is used to check such characters.