Library Symbol Properties dialog Cancel button doesn't work if a link is selected

Bug #1816636 reported by Evan Shultz on 2019-02-19
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
KiCad
Low
John Beard

Bug Description

If I open the Library Symbol Properties dialog and double-click to select the text in a field for any "normal" text box, the Cancel button works properly and closes the dialog.

If, however, the text box contains a link the Close button lights up when I click it but no action is performed. Just a single click in a link text box still works, but not after a double-click when the text is highlighted.

I will attach a video to the next post.

Application: kicad
Version: (5.1.0-rc1-36-gea84020b1), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Evan Shultz (evan-shultz) wrote :

In this video you can see me clicking on a non-link text box, a link text box just once so the whole box is highlighted, and double-clicking in the link text box to highlight the text inside the box. After each of those tasks I click the Cancel button on the dialog. When text that is a link is highlighted you can see the Cancel button being clicked but the dialog persists.

John Beard (john-j-beard) wrote :

This works for me at "5.1.0-rc1-87-g3fe8214d2" on Linux/GTK+3.

Could you try it with a more recent build? If it still happens, could be a platform issue (?)

John Beard (john-j-beard) wrote :

Scratch that, it works in eeschema, but not in libedit. Confirmed.

Changed in kicad:
status: New → Confirmed
Wayne Stambaugh (stambaughw) wrote :

That's rather ugly. I'm not even sure how this is possible unless the grid control is grabbing all of the mouse click events and not allowing them to propagate up to the parent frame window.

Changed in kicad:
status: Confirmed → Triaged
importance: Undecided → Low
Wayne Stambaugh (stambaughw) wrote :

This happens on linux as well. Someone with macos should confirm to see if it effects all platforms.

Application: kicad
Version: (5.1.0-rc1-113-g75eda6921), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 GnuTLS/3.6.4 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.32.1 librtmp/2.3
Platform: Linux 4.18.0-15-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Changed in kicad:
assignee: nobody → John Beard (john-j-beard)
milestone: none → 5.1.0-rc2
status: Triaged → In Progress
John Beard (john-j-beard) wrote :

(Janitor hat)

Fixed in revision 75406e274238cf4e02dacf542338a9a0c2ff47d4
https://git.launchpad.net/kicad/patch/?id=75406e274238cf4e02dacf542338a9a0c2ff47d4

Changed in kicad:
status: In Progress → Fix Committed
Jeff Young (jeyjey) wrote :

Yep, true on MacOS as well.

Evan Shultz (evan-shultz) wrote :

Still happens in the newest nightly under Windows.

Application: kicad
Version: (5.1.0-rc1-113-g75eda6921), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

John Beard (john-j-beard) wrote :

@Evan: 75eda6921 is the previous commit. You need "75406e274 Libedit: Fix cancel button in symbol edit dialog" or later for the fix.

Evan Shultz (evan-shultz) wrote :

Oh. Got it. Thanks John.

Confirmed fixed in:

Application: kicad
Version: (5.1.0-rc1-117-gdae7b0346), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments