Board Setup - Netclass table broken when other GUI language than English

Bug #1816315 reported by Kerusey Karyu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Undecided
jean-pierre charras

Bug Description

When the GUI language is set to other language than English, Board Setup dialog is very wide and can not be resized horizontally.

The problem is in `Net Classes` table where 8th column is very long, and seems to have no title.

I think, this is not a Polish GUI translation issue, because:
1) Even if I remove translation for this string, the column still remain very long.
2) Other languages (for ex. French, German) generate this same issue.

PO catalog looks okay:

#: pcbnew/dialogs/panel_setup_netclasses_base.cpp:55
msgid "dPair Width"
msgstr "Szerokość ścieżki pary różnicowej"

#: pcbnew/dialogs/panel_setup_netclasses_base.cpp:56
msgid "dPair Gap"
msgstr "Prześwit pary różnicowej"

Application: kicad
Version: (5.1.0-rc1-70-gd15876595), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Revision history for this message
Kerusey Karyu (keruseykaryu-deactivatedaccount) wrote :
description: updated
Revision history for this message
Kerusey Karyu (keruseykaryu-deactivatedaccount) wrote :
Revision history for this message
Seth Hillbrand (sethh) wrote :

Hmm... I only see this in Polish. In English, the words are shortened to fit the width. e.g. dPair instead of differential pair. German seems to wrap the text. Can the translation choose one of these options?

We can fix the non-readjusting issue.

Revision history for this message
Kerusey Karyu (keruseykaryu-deactivatedaccount) wrote :

The wrapped text is unreadable because the height of title row is not adjusted to two line of text.

It seems that internal procedure which adjusting the columns width into defined constrains - to fit the table on dialog box - can't handle too much text. When I untranslate some more column titles, the table behaviour (and finally dialog box) is fine.

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision d62163cc7c5b05061ca1fbb3d882ccd6b58fc058
https://git.launchpad.net/kicad/patch/?id=d62163cc7c5b05061ca1fbb3d882ccd6b58fc058

Changed in kicad:
status: New → Fix Committed
assignee: nobody → jean-pierre charras (jp-charras)
Revision history for this message
Seth Hillbrand (sethh) wrote :

@JP: Do you also want to take the grid title height issue?

Revision history for this message
jean-pierre charras (jp-charras) wrote :

I'll commit a fix soon.

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.