Wishlist: Double-clicking open FP filters in Symbol Editor

[Evan Shultz]

In the Library Symbol Properties dialog of Symbol Editor, one can click on the Footprint Filters tab and see all FP filters. Editing them requires clicking the pencil button, while double-clicking on the FP filter name to open the little Edit Footprint Filter dialog would be faster. So, if double-click to open can be added that would save a little time. Thanks!

Application: kicad
Version: (5.1.0-rc1-36-gea84020b1), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision 6de89976249a85d59fb1596086fa32764cbb3f2e
https://git.launchpad.net/kicad/patch/?id=6de89976249a85d59fb1596086fa32764cbb3f2e

[Evan Shultz (evan-shultz)]

@Seth

In the below version double-clicking anywhere in the "Footprint filters:" pane (where the FP filters are listed) opens the Add Footprint Filter dialog. This is nice for adding a new FP filter is the user clicked in a blank area of the pane.

My request was to open the Edit Footprint Filter dialog is the user clicked on an existing FP filter. Currently the New Footprint Filter dialog opens even if I click on an existing FP filter.

Application: kicad
Version: (5.1.0-rc1-90-g2dd653a32), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Seth Hillbrand (sethh)]

Hmm... That must be a Windows-specific issue. It works as you describe for Mac and Linux.

[Evan Shultz (evan-shultz)]

Perhaps it is OS-specific. Here is what I see using the same symbol and the latest nightly on Win10.

[Wayne Stambaugh (stambaughw)]

I can confirm this behavior on windows. Interestingly, hitting the escape key magically makes the filter string appear in the edit control of the dialog. A second escape key closes the dialog. This isn't one of those weird parenting issues again is it?

[Seth Hillbrand (sethh)]

@Wayne- That makes sense since the Listbox was being triggered first. Windows seems to be backwards from the other two here. I've revised this to hopefully catch the order of MSW correctly. Let me know if it doesn't fix it.

[Wayne Stambaugh (stambaughw)]

@Seth, that fixed it. Thanks!

[Evan Shultz (evan-shultz)]

Confirmed as well. Thanks Seth and Wayne!