extract_docstrings.py not py3k compatible

Bug #1815737 reported by Nick Østergaard on 2019-02-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
High
Thomas Pointhuber

Bug Description

I noticed that when building with gtk3, phoenix and python3 that make doxygen-python did not work. It seems that this is caused by using python2 only syntax.

We probably need to do a 2to3 on it and test it on both python2 and python3 builds.

The file is scripting/build_tools/extract_docstrings.py

Wayne Stambaugh (stambaughw) wrote :

This must have overlooked this when the python3 changes were made. @Thomas, do you have time to take a look at this in the near future? We definitely need to get this fixed for 5.1.

Changed in kicad:
assignee: Nick Østergaard (nickoe) → Thomas Pointhuber (pointhi)
Thomas Pointhuber (pointhi) wrote :

this patch should fix the python3 issue

Seth Hillbrand (sethh) wrote :

Tested in python3 and python2 under Buster. Both work nicely. Thanks Thomas!

KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 310e3f5eb94444f7f3c8514560b7710a0b44131d
https://git.launchpad.net/kicad/patch/?id=310e3f5eb94444f7f3c8514560b7710a0b44131d

Changed in kicad:
status: Confirmed → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers