Footprint Properties Dialog: Cancel button doesn't work if the dialog was opened up with "3D Settings" tab is pre-selected

Bug #1815456 reported by Abdullah Kahraman on 2019-02-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Undecided
Seth Hillbrand

Bug Description

In pcbnew, when opening a footprint properties dialog for a footprint, it remembers the last tab selected and selects it automatically.

Cancel button doesn't work if the dialog is preloaded with "3D Settings" tab selected, that is; the last time it was closed, it was on the "3D Settings" tab.

Here is my version info:

Application: kicad
Version: (5.1.0-rc1-5-g7789ec4bf), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Frank Severinsen (shack) wrote :

Can't replicate this here.
@Wayne didn't you do some stuff here recently?

Application: kicad
Version: 5.1.0-rc1-unknown-7b3ef1b~86~ubuntu18.10.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.32.1 librtmp/2.3
Platform: Linux 4.18.0-15-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013
Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Wayne Stambaugh (stambaughw) wrote :

Try hitting escape a second time. I don't think this was anything I did. I think wxGrid requires an initial escape to get out of the grid. wxGrid is really quirky so I'm not sure what we can do about this and still keep the grid behavior usable.

KiCad Janitor (kicad-janitor) wrote :

Fixed in revision a02f447daa5b8b44b2e0f9cdf8852157c0af1935
https://git.launchpad.net/kicad/patch/?id=a02f447daa5b8b44b2e0f9cdf8852157c0af1935

Changed in kicad:
status: New → Fix Committed
assignee: nobody → Seth Hillbrand (sethh)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers