3D file preview doesnt remember the setting when reopening FP properties

[Frank Severinsen]

HI

Steps to reproduce:
in PCBnew, open footprint properties for a footprint with a 3D model.
in 3D settings, uncheck the Preview checkbox (3D model should disappear)
press "ok, to close dialog.
reopen Footprint properties, 3D Settings.
Checkbox is still unchecked, but the 3D model is still showing

Application: kicad
Version: 5.1.0-rc1-unknown-6bb8fde~84~ubuntu18.10.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.32.1 librtmp/2.3
Platform: Linux 4.18.0-14-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Wayne Stambaugh (stambaughw)]

@Frank, I'm not seeing this. If I reopen the same footprint, the 3D model preview setting is remembered. If I open a different footprint, then the 3D model preview is enabled.

[Frank Severinsen (shack)]

@wayne the setting is kept but the actual 3D model (preview in FP properties) is shown no matter the checkbox

[Wayne Stambaugh (stambaughw)]

Duh! I missed that the model is still shown even though the preview checkbox is disabled.

[Frank Severinsen (shack)]

Not really a huge thing, but probably easy to to fix :)

[KiCad Janitor (kicad-janitor)]

Fixed in revision fe5d2b871047bb2318f4fc8fbb44cd192c13cf60
https://git.launchpad.net/kicad/patch/?id=fe5d2b871047bb2318f4fc8fbb44cd192c13cf60