PCBNew segfault on adding footprint with SMD pads

[Julien Faucher]

Hi there.

I have PCBNew crashing on adding a new footprint (segfault).

In PCBNew : Place > Footprint > Any Footprint with SMD pad > Ok > Segfault.

It might work only on squared/rectangular pads but i'm not sure.

Cheers,
Julien FAUCHER

Application: kicad
Version: 6.0.0-rc1-unknown-4cf4600~84~ubuntu18.10.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.32.1 librtmp/2.3
Platform: Linux 4.18.0-13-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Julien Faucher (suzizecat)]

This issue show up in Accelerated and Fallback modes (not in legacy)

[Seth Hillbrand (sethh)]

@Tom-

Looks like this is from the connectivity bug fix (9657039af2). I don't quite understand why you removed the m_frame->AddModuleToBoard() call in PlaceModule, so I don't want to blindly add it back. Would you have time to look into this bug?

[Seth Hillbrand (sethh)]

I added a quick work-around to check for null values but it doesn't address the underlying issue that we won't get the board-level netlist settings when drawing the modules until the modules' parent is set to the board. Was there a reason not to do this at all or was it just an order of operations issue?

[Seth Hillbrand (sethh)]

@Tom-

Please disregard. I see that you changed Added to Add (I missed this on the first look) and the module gets correctly added to the board on the click, so it was just a matter of not drawing the clearance of the module before explicitly placing. In which case, this bug is closed by 4443487f04