Pcbnew: Incorrect ratsnest after opening footprint properties

[Fabián Inostroza]

Double click on any footprint to open the properties dialog and then close it.
Pcbnew display ratsnest for the component that should not be there since all connections are done.

The same happens in 5.0.2 but in this version the ratsnest inside the pads are not shown.

See the attached video.

Application: kicad
Version: (6.0.0-rc1-dev-1437-g4d9b4428f-dirty), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.62.0 GnuTLS/3.5.19 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.35.1 librtmp/2.3
Platform: Linux 4.18.0-3-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.62.0
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=OFF

[Fabián Inostroza (fabianinostroza)]

There are other issues with ratsnest but I haven't found a way to consistently replicate them, sometimes after finishing a track the ratsnest doesn't disappear and sometimes the ratsnest aren't shown.

These issues wheren't there some weeks ago, I will try reverting some commits.

[Fabián Inostroza (fabianinostroza)]

I found that code in commit c777eac00044 triggers the issues (ratsnest not showing/disappearing and inside THT pads). If I comment line 1235 in pcbnew/tools/pcb_editor_control.cpp the the issue goes away.

To reproduce the problem open the pic_programmer demo project, delete the track that connects R10 and C4, move R10 and undo, route the net you previously disconnected. The ratsnet will still be shown after finishing the track.

[KiCad Janitor (kicad-janitor)]

Fixed in revision daee58a0ab08149fec99b63974e67d4c94e848e8
https://git.launchpad.net/kicad/patch/?id=daee58a0ab08149fec99b63974e67d4c94e848e8