Path variable management: KIGITHUB is empty but gray -> error on ok if kept empty -> warning if filled

[Rene Poeschl]

I observe a strange (and annoying) behavior with the path management dialogs.
They include the old KIGITHUB variable. however it is empty and dark gray (implying not set able by the user)

If i press ok without filling it i get an error "not allowed to leave variable empty"
If i fill it i get a warning "this path is set outside of kicad ..."

I am not sure if this is an issue of my setup, the installer or if it is an issue in kicad it self.

I am running ubuntu 16.04 (virtual machine)
With both kicad 5.0.2 and kicad nightly (both installed from the ppa)

5.0.2 also includes KIGITHUB as grayed out but it does not complain about it being empty (unless i try to edit it)

The kicad version:
Application: kicad
Version: 6.0.0-rc1-unknown-24f9bfa~84~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.15.0-43-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

A dark gray variable means it's defined in your environment. Type 'env' into a shell windows and see what it reports. You should see KIGITHUB there, although finding where it's defined can be trickier.

I'll merge a fix shortly which turns off the warnings for externally-defined variables.

[KiCad Janitor (kicad-janitor)]

Fixed in revision f6e6ac3162e22d362bb120fdf8cef1f2e9832570
https://git.launchpad.net/kicad/patch/?id=f6e6ac3162e22d362bb120fdf8cef1f2e9832570