Debug alert when starting edit symbols references

[Kerusey Karyu]

Steps to reproduce.

1. Start KiCad 5.0.2-1 and open legacy KiCad 4.0 project.

2. Start Eeschema and let Eeschema do remapping and
   rescue symbols - for backup purposes.

3. Remove rescue library and others from the project related
   table. The table should be empty.
   I wanna use My own libraries from global table *already
   used* in this project in 4.0 to manual remap. (I know My
   project and know what I'm doing).

4. Select "Edit symbol library references" tool from
   main menu.

Now the alert (see attached screenshot) will occur. The 5.0.0 release doesn't show this alert in such case.

Application: kicad
Version: (5.0.2)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

@Devs, did 5.0.2 get built with debugging on?

[Wayne Stambaugh (stambaughw)]

@Jeff, I hope we didn't. I thought we had resolved the CMAKE_BUILD_TYPE=RELWITHDEBINFO build issue after the 5.0.0 release.

[Nick Østergaard (nickoe)]

Please test with
http://downloads.kicad-pcb.org/windows/testing/kicad-5.0.2_2-x86_64.exe

[Kerusey Karyu (keruseykaryu-deactivatedaccount)]

Today's catch. I removed the old component from the library. As you can see, Eeschema lost component link. The debug asserts appears when trying to replace to the valid componnent.

Application: kicad
Version: (5.0.2)-2, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Nick Østergaard (nickoe)]

The assert seen in this bug report has been relaxed a bit on master it seems:
https://github.com/KiCad/kicad-source-mirror/commit/e33e8d02e9c95bdc277c2c490d8f03c87f6971f6#diff-e64b270f5240b2db65edda90441a56e0

But it does still not explain why asserts are enabled on a release build.