GAL Eeschema: Hierachial pin is shown behind the Hierachial sheet lines

[Frank Severinsen]

Please see attached image

Hierachial pins should be moved in front of the purple line (Hierachial sheet)
Perhaps moving the graphics one linewidth away from the edge would look even better.

Application: kicad
Version: 6.0.0-rc1-unknown-82f657e~84~ubuntu18.10.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.32.1 librtmp/2.3
Platform: Linux 4.18.0-11-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Wayne Stambaugh (stambaughw)]

I suppose we could move the pin shapes half the width of the line used to draw them but the connection indicator must remain on the outline of the sheet.

[Frank Severinsen (shack)]

Moving it forward would probably be easier for now, but I', just putting in my 2 cents

[Frank Severinsen (shack)]

Here is a patch which should (hopefully) move the Sheet pins to the front and move them in by half a linewidth.

It's my first attempt at contributing to the Kicad source code, so please go easy on me :)

Please let me know if there is anything I need to change or do.

Thank you

[Jeff Young (jeyjey)]

@Frank, something went wrong with the whitespace formatting in your patch. Do you have your editor set to output 4 spaces for tabs?

[Frank Severinsen (shack)]

@Jeff I forgot to set it up for spaces instead of tabs.
It should be fixed in the attached patch

[Jeff Young (jeyjey)]

@Frank, I had actually already reformatted your earlier patch so I merged that.

Just to make sure, you didn't make any other changes did you?

Thanks for your contribution to KiCad!

[Frank Severinsen (shack)]

@Jeff Thanks! I don't mind fixing code format things since it hopefully keeps me from making the same mistakes again.

I did not make any changes.

Thanks for the help and tutoring!

Can we set this as fixed committed?

[Jeff Young (jeyjey)]

> Can we set this as fix committed?

Yep. That's another thing I forgot to mention: look in the developer docs for details on the "fixes" script. It will put a structured comment in the commit which the janitor looks for and closes the bug for you if found (it also includes a link to the commit in the bug report, which is nice).

Cheers,
Jeff.

[Frank Severinsen (shack)]

@Jeff I didn't really expect my patch to get merged so quickly. Is it possible to add the fix commit message now?

[Jeff Young (jeyjey)]

No, but if you go to https://github.com/KiCad/kicad-source-mirror you can find the commit manually and add a link to it in the bug report.

[Frank Severinsen (shack)]

Alrighty :) thanks again!

e2ed0e6557eddf4f8ed775e5851edff1649b9ed3