pcbnew: locked footprint without user text cannot be selected, edited or unlocked

[John Beard]

* Create a PCB with a footprint that has only RefDes and Value (without %R on F.Fab)
* Lock the footprint
* Try to edit, select, or unlock this footprint - you can't.

Workaround: edit PCB file on disk and remove "locked".

Attached example minimal PCB - Try to edit the only part on that board.

----

Application: pcbnew
Version: (6.0.0-rc1-dev-1178-g62e2fe8bb), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.62.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.34.0
Platform: Linux 4.18.16-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.62.0
    Compiler: GCC 8.2.1 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

Rats. This was broken by my recent fix to deleting hidden board items.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 6d76097291c57136583fcbd3a6bd24811bb7d10e
https://git.launchpad.net/kicad/patch/?id=6d76097291c57136583fcbd3a6bd24811bb7d10e