Eeschema: support both greedy and stingy selections a la PCBNew

Bug #1798444 reported by Fabián Inostroza
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Wishlist
Jeff Young

Bug Description

Application: kicad
Version: (6.0.0-rc1-dev-937-gc22a247db-dirty), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 GnuTLS/3.5.19 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.32.0 librtmp/2.3
Platform: Linux 4.18.0-2-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=OFF

Tags: eeschema gal
summary: - Wish: Eeschema, distinguish between bottom-left selection and top-right
- selection
+ Wish: Eeschema, differentiate between bottom-left selection and top-
+ right selection
Revision history for this message
Jeff Young (jeyjey) wrote : Re: Wish: Eeschema, differentiate between bottom-left selection and top-right selection

Do you mean a selection that is dragged from top-left to bottom-right vs. one that is dragged from bottom-right to top-left? The borders are different colours, no?

Changed in kicad:
status: New → Incomplete
Revision history for this message
Fabián Inostroza (fabianinostroza) wrote :

Yes, but it always selects anything that it's partially inside the selection box, no matter how the selection was started.

In Pcbnew, a top-left started selection only selects objects that are fully enclosed by the selection box. In eeschema the same action selects anything that intersects the selection box.

Revision history for this message
Nick Østergaard (nickoe) wrote :

I think the direction aware selection is only implemented in GAL. (I didn't check it right now, so maybe you need to be sure to be in GAL)

tags: added: eeschema gal
Revision history for this message
Fabián Inostroza (fabianinostroza) wrote :

Hi Nick

I'm using the new eeschema GAL, there is no option to use legacy in the master branch.

Revision history for this message
John Beard (john-j-beard) wrote : Re: Eeschema GAL: right-left and left-right selection do the same thing

I see this in the current master. Left-right selection is a yellow-edged box, right-left is a blue-edged box. However, they both have the behaviour Fabian reports: selection of anything inside OR intersected by it. This should be the behaviour of only the blue-edged right-to-left action.

Changed in kicad:
status: Incomplete → Confirmed
summary: - Wish: Eeschema, differentiate between bottom-left selection and top-
- right selection
+ Eeschema GAL: right-left and left-right selection do the same thing
Jeff Young (jeyjey)
Changed in kicad:
importance: Undecided → Wishlist
Jeff Young (jeyjey)
summary: - Eeschema GAL: right-left and left-right selection do the same thing
+ Eeschema: support both greedy and stingy selections a la PCBNew
Revision history for this message
Jon Evans (craftyjon) wrote :

This will come as part of porting Eeschema to the new tool framework (currently only the rendering code is ported to GAL, it is still not making use of the tool framework which is what is responsible for the nicer selection behavior in PcbNew)

Changed in kicad:
assignee: nobody → Jon Evans (craftyjon)
assignee: Jon Evans (craftyjon) → nobody
Changed in kicad:
milestone: none → 6.0.0-rc1
Jeff Young (jeyjey)
Changed in kicad:
status: Confirmed → Fix Committed
assignee: nobody → Jeff Young (jeyjey)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.