Arrow keys don't work in Gerbview

[John Beard]

On the current master (db5386467), the arrow keys don't work in Gerbview to pan the view or move the cursor.

In Pcbnew:

* Arrow key: move cursor 1 pixel
* Shift-Arrow: pan view
* Ctrl-Arrow: move cursor one grid interval

Gerbview should work in the same way.

[Seth Hillbrand (sethh)]

Please add your full version information from Help->About KiCad. Many of these issues are system-dependent, so keeping track of this critical to ensuring we address the issue correctly.

[John Beard (john-j-beard)]

This isn't platform related, it's because the GERBVIEW_CONTROL class doesn't bind the cursor TOOL_ACTIONS in GERBVIEW_CONTROL::setTransitions.

In PCBNEW_CONTROL and CVPCB_CONTROL, these are bound.

In, say, Pcbnew, the actions are declared and defined. For the "Up" key:

pcbnew_actions.h

    static TOOL_ACTION cursorUp;

pcbnew_control.cpp:

    TOOL_ACTION PCB_ACTIONS::cursorUp( "pcbnew.Control.cursorUp",
        AS_GLOBAL, WXK_UP, "", "", NULL, AF_NONE, (void*) CURSOR_UP );

In Gerbview, they are only declared in gerbview_actions.h, never defined, or used.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 445a9fa963690642e14b4bb229db7aea00efddb6
https://git.launchpad.net/kicad/patch/?id=445a9fa963690642e14b4bb229db7aea00efddb6