Symbol editor crashes during various operations on OSX Mojave

[Benoît Vernier]

Hello,

I am using KiCad 5.0.0-3-g5ebb6b6 downloaded from the official build on the website, on MacOS 10.14 (full info below).

When using the symbol editor, I experience repeated crash on several operations:
- Moving the component name or field reference on a symbol I've created myself (whether saved or not doesn't change the crash, but doesn't happen on components from the official GitHub libraries). It crashes when I click to validate where I want to move the text.
- Adding a pin (same conditions as before). Again, it crashes when I click to place the pin.
- Using the search bar on the left to find a component (a bit less systematic than the others but still crashes every so often).

The MacOS crash report is attached.

KiCad Info:

Application: kicad
Version: (5.0.0-3-g5ebb6b6), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.4 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.0.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.51.0
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Seth Hillbrand (sethh)]

I can recreate this using the 5.0 nightly build.

I cannot recreate this using a local build. I also cannot recreate using one of the 5.1 nightlies.

[Seth Hillbrand (sethh)]

@Jeff- do you have a non-Mojave build that you can try this on?

[Jeff Young (jeyjey)]

I cannot reproduce this using a High-Sierra 5.1 build.

Rebuilding 5.0 to check that next....

[Jeff Young (jeyjey)]

Nope, I can't reproduce this on a 5.0.1 High-Sierra build either.

[Seth Hillbrand (sethh)]

Do you have the 10.11 SDK to build with the minimum version the same as the nightly builds or are you building against your 10.13 SDK?

I am thinking this might be build-specific. If so, we might just provide multiple builds for different OSs.

[Wayne Stambaugh (stambaughw)]

Is this stopping us from releasing 5.0.1?

[Seth Hillbrand (sethh)]

Until we can definitively say that this is a packaging issue, I think we should hold off on tagging 5.0.1. It is definitely prevents using the library editor under Mojave.

[Jeff Young (jeyjey)]

I'm building against 10.13 SDK.

[Wayne Stambaugh (stambaughw)]

I'll keep my eyes open for the fix to be committed before I tag 5.0.1.

[Seth Hillbrand (sethh)]

@Jeff-

Do you see the crash when you run the nightly build from http://downloads.kicad-pcb.org/osx/testing/5.0/ ?

[Seth Hillbrand (sethh)]

@adamwolf-

I just finished building the 5.0.1 nightly using the 10.11 SDK under Mojave. It does not exhibit this issue. How difficult would it be to update the vagrant image?

[Adam Wolf (adamwolf)]

Updating the vagrant box would be probably ~8-10 hours. The state of the art in creating vagrant base images for macOS is that you can do it with one command for macos 10.9-10.12, but 10.13 and 10.14 are done by building a 10.12 image, and then upgrading it.

Second, we have always built on the oldest system that we want to support. (We also haven't ever had issues like this in the past, where things break unless they're built on the newer OS.) Every time I look around at what other people are doing (Firefox, Chrome, brew...) they're all building on the oldest version they need to support. This may have changed, but when reading why, they said this is because of how dependencies get brought into the bundle. When you built it, do you know if every dependency that ends up in the bundle was also build with the min macOS version of 10.11? Knowing this was very hard before I did kicad-mac-builder. It should be easier to know that now, but it wasn't something I explicitly tested for.

If we want to try this, I support doing it, but we would need to do the regression test from the kicad-mac-builder README on 10.13 for sure, and it would be good to do 10.12 and 10.11. It's actually not super hard for me to do the test on 10.11, since I have the vagrant VM handy for it.

However, I do not really have more than an hour or two of time this week, so I could test a 10.14 built 5.0.1 on 10.11, but nothing really more. :( Do you think you, or another volunteer with macOS, has some time for this testing? I can outline what needs to be done and aim people at some directions tomorrow if so.

On another tangent, I saw a few other symbol editor issues this weekend here in Launchpad. Any chance those are related?

[Seth Hillbrand (sethh)]

Hi Adam-

That's useful information, thanks! If there's a better way of avoiding this issue, I'm definitely game for trying it.

There are a few possibilities for how/where this arises:
1) This is a compiler bug
2) This is a toolchain incompatibility
3) This is gremlins

If you can send me a link to a copy of the vagrant box that you use to build the 10.11, I could use that to build a debug variant and track down the issue. If this is (1) or (3), we could find it this way and fix it in code.

If it is (2), we may need to provide a second download build under Mojave. This could either be in place of the current builds or in addition.

I don't see much in the way of Library commits to the 5.0 branch. @Jeff can comment more here but I doubt much of the work in the 5.1 branch directly affects us in 5.0.

-S

[Adam Wolf (adamwolf)]

Let's timebox it. I'll get you the vagrant image, and then only spend a
bit of time on it, and i'll start getting a 10.14 image ready. We will
need it eventually anyway. If you can't get it fixed on the 10.11 image,
or it doesn't make sense, we can push forward on the 10.14 builds.

Before kicad-mac-builder, there was basically no chance of building
backwards, but it's a whole new world now :)

I will send you a private email re the vagrant image.

On Mon, Oct 1, 2018, 3:20 PM Seth Hillbrand <email address hidden>
wrote:

> Hi Adam-
>
> That's useful information, thanks! If there's a better way of avoiding
> this issue, I'm definitely game for trying it.
>
> There are a few possibilities for how/where this arises:
> 1) This is a compiler bug
> 2) This is a toolchain incompatibility
> 3) This is gremlins
>
> If you can send me a link to a copy of the vagrant box that you use to
> build the 10.11, I could use that to build a debug variant and track
> down the issue. If this is (1) or (3), we could find it this way and
> fix it in code.
>
> If it is (2), we may need to provide a second download build under
> Mojave. This could either be in place of the current builds or in
> addition.
>
> I don't see much in the way of Library commits to the 5.0 branch. @Jeff
> can comment more here but I doubt much of the work in the 5.1 branch
> directly affects us in 5.0.
>
> -S
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1795214
>
> Title:
> Symbol editor crashes during various operations on MacOS
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>

[Seth Hillbrand (sethh)]

Ugh. I am getting nowhere with this bug.

How's your progress Adam? I can help with your testing on 10.14

[Adam Wolf (adamwolf)]

I haven't really been able to work on it yet--this week is pretty brutal
for me. Can you use the 10.11 image to test the 10.14 build? I'm pretty
worried we'll be bringing in a truly epic amount of regressions if we have
to migrate from building on 10.11 to building on 10.14, but if we can't fix
the bug any other way...

Adam

On Thu, Oct 4, 2018 at 8:08 AM Seth Hillbrand <email address hidden>
wrote:

> Ugh. I am getting nowhere with this bug.
>
> How's your progress Adam? I can help with your testing on 10.14
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1795214
>
> Title:
> Symbol editor crashes during various operations on MacOS
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>

[Seth Hillbrand (sethh)]

Yes. I can do that.

[Adam Wolf (adamwolf)]

If you have more time than just testing this bug, if you could run through
the list of tests in the README and tell me which ones you tried and if
they passed or failed it would be awesome :)

On Thu, Oct 4, 2018 at 11:40 AM Seth Hillbrand <email address hidden>
wrote:

> Yes. I can do that.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1795214
>
> Title:
> Symbol editor crashes during various operations on MacOS
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>

[Seth Hillbrand (sethh)]

10.14 regression tests completed. No issues. Will look at 10.11 on the VM tomorrow.

[Adam Wolf (adamwolf)]

Awesome! Working at clearing up my schedule for next week so I can get
this handled on the build server side.

I am warming up considerably to building on 10.14 on the build box, if we
can get it to pass the packaging regression tests.

Adam

On Thu, Oct 4, 2018, 11:55 PM Seth Hillbrand <email address hidden>
wrote:

> 10.14 regression tests completed. No issues. Will look at 10.11 on the
> VM tomorrow.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1795214
>
> Title:
> Symbol editor crashes during various operations on MacOS
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>

[Seth Hillbrand (sethh)]

I've finished the various tests for 10.11 under the VM. That took quite a long time as the VM is _slow_. Also, I can't verify any of the OpenGL GAL canvas as it doesn't display. I don't know if this is a result of the emulation (Mac VM clients don't handle accelerated graphics) or if it is inherent in the build.

[Seth Hillbrand (sethh)]

@Wayne- Given that we have a possible option for Mac 5.0.1 (one build for 10.11-10.13 and one build for 10.14+), we might consider tagging the release. If the remaining tests for 10.12 and 10.13 work, we could still have a single build for Mac but worst-case is still viable.

[Adam Wolf (adamwolf)]

Can we post that 10.14 build somewhere and see if we can get some folks on
10.13 or 10.12 to see if it's working for them?

I can commit to getting 10.14 nightly builds up by Friday. Hopefully
sooner.

On Sun, Oct 7, 2018 at 5:10 PM Seth Hillbrand <email address hidden>
wrote:

> @Wayne- Given that we have a possible option for Mac 5.0.1 (one build
> for 10.11-10.13 and one build for 10.14+), we might consider tagging the
> release. If the remaining tests for 10.12 and 10.13 work, we could
> still have a single build for Mac but worst-case is still viable.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1795214
>
> Title:
> Symbol editor crashes during various operations on MacOS
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>

[Seth Hillbrand (sethh)]

Yes. If I send you a link, can you post it to the downloads section of the kicad website?

[Adam Wolf (adamwolf)]

Yup!

On Sun, Oct 7, 2018, 9:50 PM Seth Hillbrand <email address hidden>
wrote:

> Yes. If I send you a link, can you post it to the downloads section of
> the kicad website?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1795214
>
> Title:
> Symbol editor crashes during various operations on MacOS
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>

[Seth Hillbrand (sethh)]

OK, I'll set the full build options and send you a link to the package when it finishes.

[Wayne Stambaugh (stambaughw)]

@Seth, I'm fine with the solution for macos even though it is less than optimal. I do a quick check on the dev mailing list and make sure there is nothing pending. Thank you to you and Adam for wrestling with the macos packaging issues.

[Adam Wolf (adamwolf)]

I actually want to just release using the 10.14 package if we can get
someone on 10.13 (physical) to run through the packaging checklist.

I am going to be pragmatic here... I want to support all our users, but
there is a real possibility that we would spend 20+ hours supporting a
configuration with literally no users. I am willing to spend that time, but
let's do it based on user feedback, rather than preemptively. I also would
like some Wayne approval or explicit disapproval here :) Thoughts?

On Mon, Oct 8, 2018 at 8:06 AM Wayne Stambaugh <email address hidden>
wrote:

> @Seth, I'm fine with the solution for macos even though it is less than
> optimal. I do a quick check on the dev mailing list and make sure there
> is nothing pending. Thank you to you and Adam for wrestling with the
> macos packaging issues.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1795214
>
> Title:
> Symbol editor crashes during various operations on OSX Mojave
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>

[Wayne Stambaugh (stambaughw)]

I'm fine with this. I have no idea what kind of macos user base we have
but let's not spend time on something if we really don't need to. I
don't know about everyone else, but free time is in preciously short
supply these days.

On 10/8/2018 10:09 AM, Adam Wolf wrote:
> I actually want to just release using the 10.14 package if we can get
> someone on 10.13 (physical) to run through the packaging checklist.
>
> I am going to be pragmatic here... I want to support all our users, but
> there is a real possibility that we would spend 20+ hours supporting a
> configuration with literally no users. I am willing to spend that time, but
> let's do it based on user feedback, rather than preemptively. I also would
> like some Wayne approval or explicit disapproval here :) Thoughts?
>
> On Mon, Oct 8, 2018 at 8:06 AM Wayne Stambaugh <email address hidden>
> wrote:
>
>> @Seth, I'm fine with the solution for macos even though it is less than
>> optimal. I do a quick check on the dev mailing list and make sure there
>> is nothing pending. Thank you to you and Adam for wrestling with the
>> macos packaging issues.
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1795214
>>
>> Title:
>> Symbol editor crashes during various operations on OSX Mojave
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>>
>

[Adam Wolf (adamwolf)]

Sounds great.

On Mon, Oct 8, 2018 at 9:26 AM Wayne Stambaugh <email address hidden>
wrote:

> I'm fine with this. I have no idea what kind of macos user base we have
> but let's not spend time on something if we really don't need to. I
> don't know about everyone else, but free time is in preciously short
> supply these days.
>
> On 10/8/2018 10:09 AM, Adam Wolf wrote:
> > I actually want to just release using the 10.14 package if we can get
> > someone on 10.13 (physical) to run through the packaging checklist.
> >
> > I am going to be pragmatic here... I want to support all our users, but
> > there is a real possibility that we would spend 20+ hours supporting a
> > configuration with literally no users. I am willing to spend that time,
> but
> > let's do it based on user feedback, rather than preemptively. I also
> would
> > like some Wayne approval or explicit disapproval here :) Thoughts?
> >
> > On Mon, Oct 8, 2018 at 8:06 AM Wayne Stambaugh <
> <email address hidden>>
> > wrote:
> >
> >> @Seth, I'm fine with the solution for macos even though it is less than
> >> optimal. I do a quick check on the dev mailing list and make sure there
> >> is nothing pending. Thank you to you and Adam for wrestling with the
> >> macos packaging issues.
> >>
> >> --
> >> You received this bug notification because you are subscribed to the bug
> >> report.
> >> https://bugs.launchpad.net/bugs/1795214
> >>
> >> Title:
> >> Symbol editor crashes during various operations on OSX Mojave
> >>
> >> To manage notifications about this bug go to:
> >> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
> >>
> >
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1795214
>
> Title:
> Symbol editor crashes during various operations on OSX Mojave
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>

[Seth Hillbrand (sethh)]

@Adam- Sorry, the script bogged down when I was running it with --release. Somehow it was pulling in /usr/include files that python did not like. I'm adjusting the script and will send you a PR.

[Adam Wolf (adamwolf)]

Wow! Maybe the root cause is that I've only run with --release on 10.11.
Dunno yet... we'll see :)

Adam

On Tue, Oct 9, 2018 at 1:41 PM Seth Hillbrand <email address hidden>
wrote:

> @Adam- Sorry, the script bogged down when I was running it with
> --release. Somehow it was pulling in /usr/include files that python did
> not like. I'm adjusting the script and will send you a PR.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1795214
>
> Title:
> Symbol editor crashes during various operations on OSX Mojave
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>

[Adam Wolf (adamwolf)]

Hi Seth,

I have created a 10.14 VM. I am copying it to the build server but it is
22G and will take a while.

I am also making a release build with

./build.py --release --kicad-ref=5.0.1 --symbols-ref=5.0.1
--footprints-ref=5.0.1 --packages3d-ref=5.0.1 --release-name=5.0.1 --target
package-kicad-unified --translations-ref=5.0.1 --docs-tarball-url=
http://downloads.kicad-pcb.org/docs/kicad-doc-5.0.1.tar.gz
--templates-ref=5.0.1 --macos-min-version=10.11

It should be done in a few hours and then I can upload it.

Is that similar to what you did? I suspect we'll find some issues doing
this because none of our brew dependencies we're installing for the system
know they need a macos-min-version of 10.11. You got it to open on 10.11,
at least... If we end up having problems on older systems, we can upload
another build of 5.0.1 until we get this figured out for good. It wouldn't
take too long to make.

I apologize for my availability. I've been feeling a little under the
weather last week, and then it turned into a 103F fever for the last three
days...

Adam

On Tue, Oct 9, 2018 at 2:40 PM Adam Wolf <email address hidden>
wrote:

> Wow! Maybe the root cause is that I've only run with --release on 10.11.
> Dunno yet... we'll see :)
>
> Adam
>
> On Tue, Oct 9, 2018 at 1:41 PM Seth Hillbrand <email address hidden>
> wrote:
>
>> @Adam- Sorry, the script bogged down when I was running it with
>> --release. Somehow it was pulling in /usr/include files that python did
>> not like. I'm adjusting the script and will send you a PR.
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1795214
>>
>> Title:
>> Symbol editor crashes during various operations on OSX Mojave
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>>
>

[Adam Wolf (adamwolf)]

Actually, I'm going to reinstall all the brew dependencies using
--build-bottle, which should force them to be built for an old macos...

Adam

On Sat, Oct 13, 2018 at 4:10 PM Adam Wolf <email address hidden>
wrote:

> Hi Seth,
>
> I have created a 10.14 VM. I am copying it to the build server but it is
> 22G and will take a while.
>
> I am also making a release build with
>
> ./build.py --release --kicad-ref=5.0.1 --symbols-ref=5.0.1
> --footprints-ref=5.0.1 --packages3d-ref=5.0.1 --release-name=5.0.1 --target
> package-kicad-unified --translations-ref=5.0.1 --docs-tarball-url=
> http://downloads.kicad-pcb.org/docs/kicad-doc-5.0.1.tar.gz
> --templates-ref=5.0.1 --macos-min-version=10.11
>
> It should be done in a few hours and then I can upload it.
>
> Is that similar to what you did? I suspect we'll find some issues doing
> this because none of our brew dependencies we're installing for the system
> know they need a macos-min-version of 10.11. You got it to open on 10.11,
> at least... If we end up having problems on older systems, we can upload
> another build of 5.0.1 until we get this figured out for good. It wouldn't
> take too long to make.
>
> I apologize for my availability. I've been feeling a little under the
> weather last week, and then it turned into a 103F fever for the last three
> days...
>
> Adam
>
> On Tue, Oct 9, 2018 at 2:40 PM Adam Wolf <email address hidden>
> wrote:
>
>> Wow! Maybe the root cause is that I've only run with --release on 10.11.
>> Dunno yet... we'll see :)
>>
>> Adam
>>
>> On Tue, Oct 9, 2018 at 1:41 PM Seth Hillbrand <email address hidden>
>> wrote:
>>
>>> @Adam- Sorry, the script bogged down when I was running it with
>>> --release. Somehow it was pulling in /usr/include files that python did
>>> not like. I'm adjusting the script and will send you a PR.
>>>
>>> --
>>> You received this bug notification because you are subscribed to the bug
>>> report.
>>> https://bugs.launchpad.net/bugs/1795214
>>>
>>> Title:
>>> Symbol editor crashes during various operations on OSX Mojave
>>>
>>> To manage notifications about this bug go to:
>>> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>>>
>>

[Seth Hillbrand (sethh)]

I think that this one is Fix Released, would you say Adam? I don't see the issue anymore here.

[Adam Wolf (adamwolf)]

Yeah, Fix Released.

On Mon, Nov 26, 2018, 10:45 PM Seth Hillbrand <<email address hidden>
wrote:

> I think that this one is Fix Released, would you say Adam? I don't see
> the issue anymore here.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1795214
>
> Title:
> Symbol editor crashes during various operations on OSX Mojave
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1795214/+subscriptions
>

[Seth Hillbrand (sethh)]

Woo hoo! :)

[bklein (berndklein)]

in current KiCad Version (nightly build) 6.0.0-rc1-dev-1535 this issue is not longer available. So seems dev team fixed it :-)

Application: kicad
Version: (6.0.0-rc1-dev-1535-ge7fa02a9f-dirty), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.4 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.2.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002
Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Thanks
Bernd