GerbView: add action to reload files

Bug #1794004 reported by Fabián Inostroza on 2018-09-24
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nabeel Ahmad

Bug Description

Currently the only way to reload the gerber files is to do File->Clear all layer and then load the files again. A button or menu entry to reload the set of files currently loaded would be nice.

Application: gerbview
Version: (6.0.0-rc1-dev-581-g9eb574015), debug build
    wxWidgets 3.0.4
    libcurl/7.61.0 GnuTLS/3.5.19 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.32.0 librtmp/2.3
Platform: Linux 4.18.0-1-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:

Seth Hillbrand (sethh) on 2018-09-24
Changed in kicad:
status: New → Triaged
importance: Undecided → Wishlist
summary: - wish: GerbView: add action to reload files
+ GerbView: add action to reload files
tags: added: gerbview
tags: added: starter
Nabeel Ahmad (nbl14) on 2018-10-07
Changed in kicad:
assignee: nobody → Nabeel Ahmad (nbl14)
Nabeel Ahmad (nbl14) on 2018-10-07
Changed in kicad:
status: Triaged → In Progress
Nabeel Ahmad (nbl14) wrote :

All files can be reloaded using either the Toolbar or the File Menu with the attached patch. After reloading, the file order is maintained. However, if there were any empty layers between the previously loaded files, they will be filled.

Thanks @Nabeel, I tested your patch and it's working fine.

Changed in kicad:
milestone: none → 5.1.0
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 664fb234ffc27feb8c669405ae272fb28c329651

Changed in kicad:
status: In Progress → Fix Committed
Maciej Suminski (orsonmmz) wrote :

Thank you very much Nabeel. I have committed your patch to the master branch. Just FYI, I have changed tabs to spaces, so that the patch follows our coding guideline. Apart from that, well done!

Nabeel Ahmad (nbl14) wrote :

Thank you Maciej and Fabian. Glad that the patch was helpful. I'll take care of the tabs next time.

ronnie (ronnie81) on 2018-10-23
tags: removed: starter
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers