changed footprint name isn't reflected in the tree

Bug #1792243 reported by eelik on 2018-09-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Medium
Jeff Young

Bug Description

If I change the footprint name in Footprint Library Editor's "Footprint properties" nothing seems to happen. Actually the footprint exists with the new name, but it's visible in the tree view only after closing and reopening the editor, even if it is saved after renaming. The most logical behavior would be to actually change the name without copying the footprint. Copying with a new name would be OK (and safe) but it should be visible in the tree view immediately and it should then be the active footprint.

Jeff Young (jeyjey) on 2018-09-13
Changed in kicad:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Jeff Young (jeyjey)
milestone: none → 5.1.0
Jeff Young (jeyjey) on 2018-09-13
Changed in kicad:
status: Confirmed → In Progress
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision e5e1a315f19a612bc0719a5c27f2750edcb68c43
https://git.launchpad.net/kicad/patch/?id=e5e1a315f19a612bc0719a5c27f2750edcb68c43

Changed in kicad:
status: In Progress → Fix Committed
eelik (eelik) wrote :

This seems to work logically now. The changed name is saved without confirmation, even if the editor is closed without saving, so I hope it doesn't bite anyone. But it does what is expected.

Jeff Young (jeyjey) wrote :

Hmmm... that's not great. I think I need to add a confirmation dialog.

Changed in kicad:
status: Fix Committed → Triaged
Jeff Young (jeyjey) wrote :

Well, the confirmation dialog was clunky. It just felt wrong.

I've managed to finesse it such that it doesn't save the changes in the module (and library tree) until you save.

Changed in kicad:
status: Triaged → In Progress
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision a5e2ddd65a38f9677bc1667a68d9bd06302678ce
https://git.launchpad.net/kicad/patch/?id=a5e2ddd65a38f9677bc1667a68d9bd06302678ce

Changed in kicad:
status: In Progress → Fix Committed
Jeff Young (jeyjey) wrote :

@eelik, if you could give this new version a spin I'd appreciate it.

Cheers,
Jeff.

eelik (eelik) wrote :

Now it feels right and natural, all changes including renaming are equal. I tested different scenarios of opening, modifying, renaming and saving footprints, and can't find a way to make it fail. Together with fixes for #1792256 everything works fine.

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers