// parent of this dialog cannot be NULL since that breaks the Kiway() chain.
HTML_MESSAGE_BOX dlg( parent, _( "Not Found" ) );
Well, yes, and it also can't be NULL because it segfaults on OSX.
I followed the git history, but all of this was added in a single commit with a slew of other stuff, so there's no data about why setting parent was commented out.
We have these somewhat ironic lines in PROJECT::SchLibs():
wxWindow* parent = 0; // Pgm().App( ).GetTopWindow( );
// parent of this dialog cannot be NULL since that breaks the Kiway() chain. MESSAGE_ BOX dlg( parent, _( "Not Found" ) );
HTML_
Well, yes, and it also can't be NULL because it segfaults on OSX.
I followed the git history, but all of this was added in a single commit with a slew of other stuff, so there's no data about why setting parent was commented out.
I replaced it, and at least it doesn't crash now.