False positive DRC error

[Fabián Inostroza]

The DRC always shows that a pin is disconnected and a ratsnest is shown, see the attached image and project.

This doesn't happen in the 5.0 branch.

Application: kicad
Version: (6.0.0-rc1-dev-445-ga6325aab2), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 GnuTLS/3.5.19 zlib/1.2.11 libidn2/2.0.4 libpsl/0.20.2 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.32.0 librtmp/2.3
Platform: Linux 4.17.0-3-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=OFF

[Fabián Inostroza (fabianinostroza)]

This was introduced by commit 6765ab6975
https://git.launchpad.net/kicad/patch/?id=6765ab6975f131cda092bc129e1e606be1fb09f5

[jean-pierre charras (jp-charras)]

There is no bug:

From the POV of Pcbnew the pad is actually not connected to the zone:
For calculation time reason, a pad is seen as connected to a zone only if its reference point (its center) is *inside* the zone.
Here, the pad center is not inside the zone, and it is not connected to the zone.

the commit 6765ab6975 fixed a bug that missed some ratsnests.
And the pad was seen as connected just because its ratsnest was missed.