PANEL_SETUP_TRACKS_AND_VIAS::validateData() does not check Differential Pairs

Bug #1789293 reported by Thomas Pointhuber on 2018-08-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Undecided
Jeff Young

Bug Description

In "File" -> "Board Setup" -> "Tracks & Vias" I can, for example, enter negative with for Differential Pairs and no error dialog appears when pressing OK. This happens because the validateData() method in PANEL_SETUP_TRACKS_AND_VIAS does not check Differential Pairs, only Tracks, and Vias.

Issue found while fixing: https://bugs.launchpad.net/kicad/+bug/1788877

# Version Information

Application: kicad
Version: (6.0.0-rc1-dev-385-g92ffa91c7-dirty), debug build
Libraries:
    wxWidgets 3.1.1
    libcurl/7.61.0 OpenSSL/1.1.0i zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.32.0
Platform: Linux 4.18.3-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.1.1 (wchar_t,wx containers) GTK+ 2.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: Clang 6.0.1 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Jeff Young (jeyjey) on 2018-09-01
Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
status: New → In Progress
milestone: none → 5.1.0
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 72cf340119386c2557f75295aa1781a406d51b61
https://git.launchpad.net/kicad/patch/?id=72cf340119386c2557f75295aa1781a406d51b61

Changed in kicad:
status: In Progress → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers