always show edit icons in grid, and make them ubiquitous

[Thomas Pointhuber]

For example, when editing specific Symbol Properties like Footprint or Datasheet, an icon is displayed right in the text entry which allows to search for a footprint/open a web browser.

This is a good idea and should be improved further:

* display the icon all the time. This allows the user to spot entries with such features more easily and speed-up the workflow (No double-click on text input required)
* add a directory/file browser icon as well, and implement them in all table widget entries which are working with paths/directories (Path Configuration, Library Configuration,...). Please note if possible the native file browser should be used, because this is the one that users are familiar with (and they have more features than the self-written-ones)

# System information

Application: kicad
Version: (6.0.0-rc1-dev-373-g32d262b0f), debug build
Libraries:
    wxWidgets 3.1.1
    libcurl/7.61.0 OpenSSL/1.1.0i zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.32.0
Platform: Linux 4.18.3-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.1.1 (wchar_t,wx containers) GTK+ 2.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: Clang 6.0.1 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

Sadly it's rather difficult to get wxWidgets to agree to the "show always" part. But I'll make another attempt at it when I have some spare time if someone else doesn't get there first.

[Thomas Pointhuber (pointhi)]

Jeff: please note the main bug report is about having a file browser opened by the edit icon. Permanent icons are a separated item.

[Thomas Pointhuber (pointhi)]

Initial patchset which adds a cell editor for directories to the path dialog:

https://github.com/pointhi/kicad-source-mirror/commits/directory_button_helper

[Jeff Young (jeyjey)]

Apologies, Thomas, I thought I had annotated this bug report.

I already added it to the Configure Paths dialogs.

My impl differs from yours only in that it keeps track of the current directory so that it can be used uniformly in other places. (That's what I meant by the "ubiquitous" part of the bug title.)

[KiCad Janitor (kicad-janitor)]

KiCad bug tracker has moved to Gitlab. This report is now available here: https://gitlab.com/kicad/code/kicad/-/issues/2223