Table Widget: delete not working in some dialogs

[Thomas Pointhuber]

# HowTo reproduce

1. "Kicad" -> "Settings" -> "Configure Paths"
2. add a new entry
3. try to delete new entry

# Expected behavior

delete button actually deletes the entry

# System information

Application: kicad
Version: (6.0.0-rc1-dev-373-g32d262b0f), debug build
Libraries:
    wxWidgets 3.1.1
    libcurl/7.61.0 OpenSSL/1.1.0i zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.32.0
Platform: Linux 4.18.3-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.1.1 (wchar_t,wx containers) GTK+ 2.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: Clang 6.0.1 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

@Thomas, does it work if you re-select the new entry, or can you not delete items from the grid at all?

(I can't reproduce this on OSX.)

[Thomas Pointhuber (pointhi)]

Video: https://cloud.oe5tpo.com/s/M4qQoiPs4QzJeTt

I found another weird thing: setting an invalid path causes an info-box to appear, and pressing OK closes the dialog and writes the configuration. The dialog should at least have a cancel button when the user finds out he did something wrong.

[Jeff Young (jeyjey)]

Hi Thomas,

The flashing suggests that it’s beeping; is that correct?

That would help me narrow it down...

[Thomas Pointhuber (pointhi)]

I never experienced any sound output from KiCad.

[Thomas Pointhuber (pointhi)]

Jeff, I did some debugging:

https://github.com/KiCad/kicad-source-mirror/blob/master/common/dialogs/dialog_configure_paths.cpp#L373

m_SearchPaths->HasFocus() seems to return False all the time. Commenting out the focus check fixes the bug. I verified it for WX 3.0 as well as 3.1 on my system.

[Mathieu Magne (patsux)]

Hi,

On my Linux, the row does not change its color on the left click, meaning the grid has not the focus. Maybe we should fix this instead of removing the HasFocus() check ?

BTW, the V5 disables the delete button when an immutable variable is selected. Should we keep this behavior ?

(I'm a new Kicad user)

# System information

Application: kicad
Version: (6.0.0-rc1-dev-373-g32d262b0f), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 OpenSSL/1.1.0i zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.32.0
Platform: Linux 4.18.4-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 8.2.0 with C++ ABI 1013
Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

Cool. I’ve changed it to highlight rows (which are visible even without focus), so that line is now surplus to requirements anyway.

Cheers,
Jeff.

> On 25 Aug 2018, at 14:32, Thomas Pointhuber <email address hidden> wrote:
>
> Jeff, I did some debugging:
>
> https://github.com/KiCad/kicad-source-
> mirror/blob/master/common/dialogs/dialog_configure_paths.cpp#L373
>
> m_SearchPaths->HasFocus() seems to return False all the time. Commenting
> out the focus check fixes the bug. I verified it for WX 3.0 as well as
> 3.1 on my system.
>
> --

[Jeff Young (jeyjey)]

Also FP Options and Setup Netclasses.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 21eea1f56718c3b9e7fba6a3db551b99ea6d8e06
https://git.launchpad.net/kicad/patch/?id=21eea1f56718c3b9e7fba6a3db551b99ea6d8e06